Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces the UV_NO_SYNC environment variable to the CI workflow and updates multiple dependency versions. However, the PR contains critical issues that need to be addressed.
Changes:
- Added
UV_NO_SYNC=1environment variable to prevent dependency sync during CI runs - Removed
--frozenflags fromuv runcommands in the test execution steps - Updated four direct dependencies in pyproject.toml to newer versions (azure-monitor-opentelemetry, greenlet, ruff, ty)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/pull_request.yaml | Adds UV_NO_SYNC environment variable and removes --frozen flags from test commands |
| pyproject.toml | Updates minimum versions for azure-monitor-opentelemetry, greenlet, ruff, and ty dependencies |
| uv.lock | Regenerates lockfile with updated versions for multiple transitive and direct dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Unit tests | ||
| run: uv run --frozen -- pytest --cov=python_template --cov-branch tests/unit | ||
| run: uv run -- pytest --cov=python_template --cov-branch tests/unit |
There was a problem hiding this comment.
Removing the --frozen flag from uv run commands is inconsistent with the purpose of UV_NO_SYNC. The --frozen flag ensures that uv runs with the exact dependencies specified in the lockfile without attempting to update them, which is critical for reproducible CI builds. Without this flag, uv may attempt to resolve dependencies differently than what's in the lockfile, potentially causing build inconsistencies. The --frozen flag should be retained to ensure deterministic builds.
1 participant
No description provided.